search

dxos / registry-client

Registry Client
GNU Affero General Public License v3.0
1 stars 1 forks source link

Remove or amend graphql endpoint check #42

Closed ccamrobertson closed 4 years ago

ccamrobertson commented 4 years ago

When using registry-client with /api as an endpoint, it will return a /graphql endpoint. We either need to remove the check or amend to accept /api. The former is preferred unless there is strong rational to do a check.

See https://github.com/dxos/dashboard/issues/44 in dashboard for more information on why this is the case.

cc @telackey to watch for config-prod.yml endpoint update.

ashwinphatak commented 4 years ago

@ccamrobertson, yes, that rewrite doesn't make sense, not sure why it was created.

Fixed, can you bump registry-client to latest in dashboard.

"@wirelineio/registry-client": "^0.4.5" and try?

ccamrobertson commented 4 years ago

Looks good, thanks.