search

dxprog / anime-bracket

The code that runs animebracket.com
http://animebracket.com
84 stars 20 forks source link

[Enhancement]Support additional media types in character view #6

Closed RouganStriker closed 4 years ago

RouganStriker commented 9 years ago

Notably videos; if a link to a video is specified in the "Link to Picture" field on the nomination form, on the corresponding character view, use that link to generate an embedded video player (works for youtube, vimeo, etc links). A button will take the place of where an image would be displayed and its function is to hide/show the embedded video player; similar to how videos are displayed inline by the Reddit Enhancement Suite.

dxprog commented 9 years ago

Detecting URLs and linking to them I can do, but I don't think I've got the time to put into an embedded player, especially for multiple services.

RouganStriker commented 9 years ago

That's fine, I can look into the latter if you also think this would be a worthwhile enhancement to make.

chiefnoah commented 9 years ago

What about having the video in an overlay? It could be easier to implement(?) and wouldn't displace the rest of the markup.

dxprog commented 9 years ago

Yeah, overlay vs inline is less the problem. If this is supposed to replace the image field, we'd need to call APIs to these services to retrieve thumbnails of the video. Also, would probably need a field or some way to identify an item as being a video (maybe the source field is disabled and the link stored there). Ideally, there'd be a scalable system built around that so more services could be added in the future. Any way you spin it, doing it correctly is a non-trivial amount of work (arguably, a lot of things need to be refactored in general...).

The short term solution is to allow links in the source field and link out when one is detected.

chiefnoah commented 9 years ago

I probably shouldn't do this stuff when I'm supposed to be paying attention in class... I didn't even think about the actual work that would have to go into it to make it work

dxprog commented 9 years ago

Heh. I've just been in the industry so long, I'm automatically figuring out everything that must be done and any way of convincing project managers to either give more time or scale back ;)

dxprog commented 4 years ago

Closing as dupe of #27 (which is in progress)