dxv2k / CS112.L12.KHCL

Solution for labs
1 stars 1 forks source link

Review BOT exercise! #5

Closed VinhDevNguyen closed 4 years ago

VinhDevNguyen commented 4 years ago

Review BOT exercise!

If there are any problem, please comment below. If not, tick 'x' on 1.1. BOT (Built-Operation-Transfer), close commit and merge branch BOT_Vu_solution to master

VinhDevNguyen commented 4 years ago

https://github.com/dxv2k/CS112.L12.KHCL/blob/ec28de4e35e4c8ebd14d09d6c78050e9f4b27327/Week1/BOT/solution.py#L1-L18 Đoạn code này ông @dxv2k đã tính đến trường hợp nếu có nhiều cách chọn thì chỉ ra cách chọn có p nhỏ nhất như đề bài đã ghi chưa?

VinhDevNguyen commented 4 years ago

Checkout and compare my solution with @dxv2k solution!

My solution

https://github.com/dxv2k/CS112.L12.KHCL/blob/243f5c7dd448393e328c7fd5e69eed90ced9a95f/Week1/BOT/Vinh_Solution.py#L1-L15

@dxv2k solution

https://github.com/dxv2k/CS112.L12.KHCL/blob/ec28de4e35e4c8ebd14d09d6c78050e9f4b27327/Week1/BOT/solution.py#L1-L18

dxv2k commented 4 years ago

In algorithm design, must use pseudo-code

VinhDevNguyen commented 4 years ago

Ok, I will add it into Jupiter notebook version a.s.a.p

VinhDevNguyen commented 4 years ago

I created Jupiter Noteboook version, @Dokkaebi00 will take care of the code and I will review it later. If every thing OK. Merge your branch into master branch.

VinhDevNguyen commented 4 years ago

Please do this a.s.a.p cause deadline is Due Sep 18

VinhDevNguyen commented 4 years ago

Missing desciption of Temporary variable, Condition and Description of algorithm (Write psudo code in description) @Dokkaebi00 Please add these in Jupiter Notebook file a.s.a.p

VinhDevNguyen commented 4 years ago

@dxv2k Review this file and the JupiterNotebook version of BOT exercise before we merge BOT_Quang_solution branch into master branch.

VinhDevNguyen commented 4 years ago

Done!