search

dxvid-pts / miniplayer

A lightweight flutter package to simplify the creation of a miniplayer.
https://pub.dev/packages/miniplayer
MIT License
107 stars 79 forks source link

type 'int' is not a subtype of type 'double' #15

Closed shahmirzali49 closed 3 years ago

shahmirzali49 commented 3 years ago

when dismissing giving this error - > type 'int' is not a subtype of type 'double'

toklive commented 3 years ago

I am getting the same when the device goes to portrait mode..

I am using ValueNotifier for miniplayer..

final ValueNotifier customValueNotifier = ValueNotifier(MediaQuery.of(context).size.height);

Miniplayer( controller: _videoController.miniPlayerController, valueNotifier: customValueNotifier, minHeight: _playerMinHeight,

Here is the call stack..

/flutter (10556): _ValueListenableBuilderState#7a816): I/flutter (10556): type 'int' is not a subtype of type 'double' I/flutter (10556): I/flutter (10556): The relevant error-causing widget was: I/flutter (10556): Miniplayer I/flutter (10556): lib/…/views/home_view.dart:55 I/flutter (10556): I/flutter (10556): When the exception was thrown, this was the stack: I/flutter (10556): #0 borderDouble package:miniplayer/src/utils.dart:24 I/flutter (10556): #1 _MiniplayerState.build. package:miniplayer/miniplayer.dart:169 I/flutter (10556): #2 _ValueListenableBuilderState.build package:flutter/…/widgets/value_listenable_builder.dart:187 I/flutter (10556): #3 StatefulElement.build package:flutter/…/widgets/framework.dart:4691

shahmirzali49 commented 3 years ago

Did you solve or? I solved, add github and add to protect from github url, like package

toklive commented 3 years ago

Is this package/repo is been maintained? Not seeing any response recently on any issues....

toklive commented 3 years ago

Did you solve or? I solved, add github and add to protect from github url, like package

Nope I didn't resolve it yet. How did you resolve ? Any plan to merge it with this package via PR ?

shahmirzali49 commented 3 years ago

@toklive - https://github.com/Shahmirzali-Huseynov/miniplayer_for_araf

no, I'm not owner this package, there is the link above solved version.

shahmirzali49 commented 3 years ago

add pubspecyaml

miniplayer: git: url: git://github.com/Shahmirzali-Huseynov/miniplayer_for_araf.git

shahmirzali49 commented 3 years ago
Screen Shot 2021-06-24 at 00 03 36

like this

shahmirzali49 commented 3 years ago

also you can add your repository and use it from there

toklive commented 3 years ago

Great thank you. I will do also I may send a PR with the change..

toklive commented 3 years ago

I just did the same change and pushed for PR here.. I will my local repo for the time being like you did.

shahmirzali49 commented 3 years ago

I don't know unfortunately

dxvid-pts commented 3 years ago

I'll take a look this week!

steevedevops commented 3 years ago

I solved this problem..