search

dxw / accessibility-manual

How we do accessibility at dxw
https://accessibility.dxw.com
3 stars 1 forks source link

Add JavaScript for toggle buttons in navigation #92

Open lookupdaily opened 10 months ago

lookupdaily commented 10 months ago

Opening an issue for the below comment from #90

Not a blocker, but it would be good to make a point of user researching the checkbox toggle method used here at a future date as I'm not sure it's a widely used approach compared to button toggles with JavaScript. There may be a good reason why it isn't widely used.

There's this from Inclusive Components toggle-button - that makes a good point that:

The trouble with using form elements is their longstanding association with the collection of data

_Originally posted by @calumryan in https://github.com/dxw/accessibility-manual/pull/90#discussion_r1446063974_

As we'd like to test out the toggle navigation, will work separately on changing this to a more conventional button+JavaScript combination, with a possible fallback for without JS

As we do not currently have any JavaScript in the project, we may want to do some initial setup for this, following the example in the playbook - or could take a more simple approach for this one off use.

yndajas commented 5 months ago

@lookupdaily and is this one closed by #93?