search

dxw / dxw-security-wp-plugin

A WordPress plugin which pulls in security reviews of other plugins from https://security.dxw.com and displays them on the plugins page and dashboard
http://wordpress.org/plugins/dxw-security/
2 stars 0 forks source link

PHP Notices from dashboard widget #3

Open JDGrimes opened 10 years ago

JDGrimes commented 10 years ago

I just noticed the following notices in my debug log:

[18-Aug-2014 14:29:05 UTC] PHP Notice:  Undefined property: dxw_security_Dashboard_Widget::$first_vulnerable_slug in /Users/johngrimes/svn/wordpress/trunk/src/wp-content/plugins/dxw-security/lib/dashboard_widget.class.php on line 51
[18-Aug-2014 14:29:05 UTC] PHP Notice:  Undefined property: dxw_security_Dashboard_Widget::$vulnerable in /Users/johngrimes/svn/wordpress/trunk/src/wp-content/plugins/dxw-security/lib/dashboard_widget.class.php on line 64

Using version 0.2.8 on PHP 5.5 and a local install of WordPress latest SVN trunk.

dgmstuart commented 10 years ago

Oops! Sorry about that: looks like I forgot to declare the variables. I'll get that fixed and hopefully release an update in the next couple of days. Many thanks for letting me know!

dgmstuart commented 10 years ago

OK, I've fixed this on master, but if it's OK with you, I'll hold off releasing a new version until there's some functionality to release.

Here's the commit: https://github.com/dxw/dxw-security-wp-plugin/commit/34448b4ea29e8563566da4ff131b16b9d9b51263

JDGrimes commented 10 years ago

Yep, that’s find with me. Thanks.

smeric commented 9 years ago

Hi,

It seems that this commit wasn't effective for an unknown reason... those errors are still there whatever 0.2.8 version i use : the one on wordpress.org or the one in this git repo...

By the way, and for information, are you still maintaining this plugin ?

Thanx for your work on this.

dgmstuart commented 9 years ago

@smeric Hi - yes, i'm afraid we never did make another release of the plugin.

We'll ultimately be switching off the api which backs this plugin, in favour of https://www.mongoosewp.com/ - a paid service which emails users about proven vulnerabilities in plugins they have installed.

The data which this plugin made visible will continue to be freely available on https://security.dxw.com/ but we've found that the current presentation of that data in the plugin is quite misleading and confusing to many users. The work to make it into a service we're happy to put our name to ongoing isn't something we're able to take on at the moment.

We feel like mongooseWP is a much clearer and more useful service - it would be great to get your feedback on the idea.

Hope that all makes sense - happy to discuss further.

smeric commented 9 years ago

Well, it seems to me a more reliable way to deal with plugins vulnerabilities warnings :)

Thanks for making me know about this new service of yours. I'll keep that in mind in case some of my customers want this kind of service...

I wish you the best.