search

dxw / govuk-theme

A WordPress theme implementing the GOV.UK design system
MIT License
17 stars 7 forks source link

Restructure Sass partials to mirror structure of GOV.UK Frontend #52

Closed matthewpassmore closed 2 years ago

matthewpassmore commented 2 years ago

This PR improves alignment between how the theme and the GOV.UK Frontend structure Sass partials. The new folders and files help remove ambiguity in the intent of each partial. For example, previous projects have had global mixins and settings defined in inconsistent locations, but the GOV.UK Frontend explicitly uses the helpers and settings folders which help communicate intent and maintain a hierarchy of imports.

New tree structure:

assets/scss ├── base ├── components ├── helpers ├── objects ├── overrides ├── settings └── templates

See https://github.com/alphagov/govuk-frontend/tree/main/package/govuk for reference.

matthewpassmore commented 2 years ago

@RobjS thanks for the feedback. I've made relevant changes and tidied up the commit history accordingly.

The helper mixins included are a combination of those I've used regularly in the past, and those used on previous GovPress projects added by other team members. The aspect-ratio helper is particularly helpful but will be phased out in time as we adopt CSS aspect-ratio; https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio.