search

dxw / js-cop-games

A repo for the Javascript community of practice's games
0 stars 0 forks source link

Tidy up domManipulationUtils #229

Closed yndajas closed 2 weeks ago

yndajas commented 2 weeks ago

@richpjames yeah that's fair! I did think this didn't feel ideal - it was a rush job when adding something new! My aim with the alphabetisation was (1) to make it easier to browse through the utils to get a sense of what already exists (derender functions, render functions, a few other functions, some custom types etc) and (2) to reduce the amount of thinking that goes into deciding where to put new functionality. But I think a better solution would be to start breaking this file down into multiple files based on the code that changes together stays together principle

richpjames commented 2 weeks ago

Yeah there's definitely good reasons to alphabetize it and I agree the best option would be to break it down a bit. I'm going to approve this so you can go ahead if you'd like