search

dxw / whippet-server

Whippet Server launches a stand-alone web server for a specific WordPress installation. It makes WordPress easier to develop with, for example, by adding lots of debug information to the terminal without cluttering up or breaking your templates.
ISC License
80 stars 6 forks source link

Replacing calls to Colours::fg('white') with an off() function #65

Closed tommorris closed 8 years ago

tommorris commented 8 years ago

This is designed to make it so colours don't spill out of the script and cause irritation to users. Also, because the white colour is often hard to read against a white background (such as the stock OS X Terminal.app UI which uses a light grey).

See screenshots below.

Before

screen shot 2016-06-09 at 15 49 06

After

screen shot 2016-06-09 at 15 50 09

tommorris commented 8 years ago

(Kindly ignore the pcntl warning. Fixed on my machine now.)

dgmstuart commented 8 years ago

@tommorris my initial reaction was "Wait, but what happens on dark terminals?". Then I saw the diffs and was like 😮 👍 👍