Move getCMR42Contours to ThirdPartyToolbox

[GoogleCodeExporter]

No sufolders inside of toolboxes. 

https://code.google.com/p/gerardus/source/browse/#svn%2Ftrunk%2Fmatlab%2FCardiac
Toolbox%2FgetCMR42Contours%253Fstate%253Dclosed

And getCMR42Contours is derivative from a third party toolbox too.

This should go in the ThirdPartyToolbox, in a subfolder with the toolbox name, 
e.g. ThirdPartyToolbox/BlahBlahToolbox.

First, the original third party code is added and commited. 

Then, you apply your changes, and add near their copyright/licence snippet 
something along the lines of 

% This is a derivative work of the original BlahBlah toolbox.
% Author: Tasos <tasos@foo.com>
% Version: 0.1.0
% $Date$
% $Rev$
%
% Summary of changes:
%
% * modified GUI to select several files at the same time.
% * change of colours.

The script add_gerardus_path.m will pick up the new 
ThirdPartyToolbox/BlahBlahToolbox folder and add it to the path, anyway.

Original issue reported on code.google.com by rcas...@gmail.com on 5 Nov 2014 at 12:37

[GoogleCodeExporter]

Note: Even if you make modifications to somebody else's code, it's still a 
third party toolbox. We cannot change the copyright, or the licence unless 
their licence allows us to do so.

If you write a completely new function from scratch that calls somebody else's 
function, that's a different case. That completely new from scratch function 
has our copyright and licence, and it goes in one of our toolboxes (in this 
case, probably in FileFormatToolbox).

Original comment by rcas...@gmail.com on 5 Nov 2014 at 12:41

[GoogleCodeExporter]

ah, sorry Ramon, I missed this second email.
Yes, I can confirm that the getCMR42Contours is a function from scratch.

Original comment by tasos.pa...@gmail.com on 5 Nov 2014 at 8:31

[GoogleCodeExporter]

Ok, then getCMR42Contours.m should go to matlab/FileFormatToolbox, and the rest 
of the functions currently in matlab/CardiacToolbox/getCMR42Contours should go 
to ThirdPartyToolbox!

Note that in the end, all toolboxes get added to the path, so it's not a big 
problem where each function is.

Also, note some problems with getCMR42Contours.m:

- In the help header, the function is called getContours, even though its 
actual name is getCMR42Contours.

- The "svn properties" haven't been set.

- The version number should be 0.1.0, not 0.1.

But excellent work, in any case.

Original comment by rcas...@gmail.com on 5 Nov 2014 at 9:01

[GoogleCodeExporter]

Zombie issue, not started in 5 weeks. To be put out of it's misery, files will 
be deleted.

Original comment by rcas...@gmail.com on 11 Dec 2014 at 5:49

• Changed state: WontFix

[GoogleCodeExporter]

Yes I agree, these files are no longer relevant.
Sorry, should have deleted ages ago.
Thanks for resolving.

Original comment by tasos.pa...@gmail.com on 11 Dec 2014 at 6:38