search

dxwdxw2005 / gerardus

Automatically exported from code.google.com/p/gerardus
0 stars 0 forks source link

Wrong function format and missing stuff in some functions in private-gerardus #7

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Missing:
 copyright, licence, subversion properties (Rev, Date and native), checking input/output arguments.

Format problems:
 function names must start with lower case.

matlab/CardiacToolbox/ImgCrossProduct.m
matlab/CardiacToolbox/ImgDotProduct.m
matlab/CardiacToolbox/ImgNormalise.m
matlab/CardiacToolbox/IsImgNormalised.m
matlab/CardiacToolbox/conv_hull_3D.m

Original issue reported on code.google.com by rcas...@gmail.com on 29 Oct 2014 at 12:20

GoogleCodeExporter commented 8 years ago 
Also, help headers don't have the right format (you can see an example here: 
https://code.google.com/p/gerardus/source/browse/trunk/matlab/CardiacToolbox/blo
ckface_intraframe_reg.m)

The missing subversion properties are:

svn propset svn:eol-style native foo.m
svn propset svn:keywords "Rev Date" foo.m

You can see examples of help header format and

Original comment by rcas...@gmail.com on 29 Oct 2014 at 12:34

GoogleCodeExporter commented 8 years ago 
PS. All those files have the property svn:executable. But they are Matlab text 
files. They should not be executables, right?

Original comment by rcas...@gmail.com on 29 Oct 2014 at 1:45

GoogleCodeExporter commented 8 years ago

Original comment by rcas...@gmail.com on 4 Nov 2014 at 12:33

GoogleCodeExporter commented 8 years ago

Original comment by vcarape...@gmail.com on 5 Nov 2014 at 1:12