Runtime bug: [Linux] Taking screenshots doesn't work when built with SDL 1.2 (SDL2 wrapper?)

[neodyne]

Environment

• dxx-rebirth compiled from master (https://github.com/dxx-rebirth/dxx-rebirth/commit/ebe4aceb721894ff614481e97c50df0fd7e3e814), sdl1.2 build
• all dependencies installed

  git clone https://github.com/dxx-rebirth/dxx-rebirth
  cd dxx-rebirth
  scons

Operating System Environment

• Ubuntu

  • [ ] Ubuntu 20.04 LTS (Focal Fossa)
  • [ ] Ubuntu 22.04 LTS (Jammy Jellyfish) <- fine here
  • [ ] Ubuntu 23.10 (Mantic Minotaur)
  • [x] Ubuntu 24.04 LTS (Noble Numbat)

• Linux Mint

  • [x] Linux Mint 22 (Wilma), Mate edition (same package base as Ubuntu 24.04 LTS)

CPU environment

• [ ] x86 (32-bit Intel/AMD)
• [x] x86_64 (64-bit Intel/AMD)
• [ ] ARM (32-bit)
• [ ] ARM64 (64-bit; sometimes called AArch64)

Description

Presing PrintScreen in-game opens system screenshot manager (mate-screenshot), instead of creating an image in ~/.d{1,2}x-rebirth/screenshots/.

Regression status

Issue doesn't occur:

• with the same configuration on previous Ubuntu LTS (Jammy Jellyfish), or Mint based on it (Virginia)
• with appimage builds from Github Actions (built on jammy?)
• with scons sdl2=1

Steps to Reproduce

• Expected behavior: While in-game, after pressing PrintScreen, screenshot of the game is saved to ~/.d{1,2}x-rebirth/screenshots/.

• Observed behavior: No screenshot is saved, instead a system menu for saving screenshots is opened.

• Engines affected:

  • [x] D1X-Rebirth
  • [x] D2X-Rebirth

• Game modes affected: ~all

This may be related to Mint / Ubuntu / Debian switching from an actual SDL1.2 lib ( jammy ) to an SDL2 wrapper ( noble ). On another machine with Ubuntu 22.04 and libsdl1.2==1.2.15, the game "captures" PrintScreen (and also e.g. the Super key) while running, and screenshots work.

[vLKp]

The contributed Github Actions workflow for building a Linux AppImage uses Ubuntu 22.04. Presumably, that AppImage bundles the SDL1.2 that Ubuntu 22.04 uses, which would be consistent with your observation that the Ubuntu 22.04 SDL1.2 behaves as desired. I do not know how to statically unpack an AppImage to confirm the version of the libraries embedded in the AppImage.

The game is dependent on your input subsystem passing the screenshot key to the game in order to request a screenshot. If the input subsystem is intercepting the screenshot key and displaying a menu, instead of passing the key to the game, then the game cannot know that you requested a screenshot, and cannot create one.

If you start the game with -debug, does the game's d2x-gamelog.txt report when the printscreen key is pressed? For me, with a working build, I see:

Sending event event_type::key_command:      PRSCR

If this does appear, then the problem is that the game is mishandling the keypress. If this does not appear, then the problem is that something outside the game is intercepting the key and diverting it to the external screenshot manager.