search

dxxxxy / EssentialCosmeticsUnlocker

Client-side only patch that allows you to unlock ALL cosmetics (+ emotes) in the Essential mod. Works on every version of Essential MC (1.8.9 - 1.20.6).
GNU General Public License v3.0
74 stars 6 forks source link

Suggestion to change the data path #35

Open MacaylaMarvelous81 opened 4 months ago

MacaylaMarvelous81 commented 4 months ago

Currently, the cosmetic data dump and config file are located at $LOCALAPPDATA. This corresponds to <user>/AppData/Local on Windows, but it could be undefined on other environments, such as on a Linux installation, which means the user will have to define $LOCALAPPDATA themselves.

I suggest using a subdirectory in the Minecraft game folder since game data, including mods, are usually placed there, users won't need to deal with any additional configuration, and it would keep profiles/instances separate if the user has multiple.

dxxxxy commented 3 months ago

APPDATA (roaming) will be used instead. It is impossible to use Minecraft's dir variable as it does not exist in later versions of the game and breaks universal compatibility (I encountered it just now).

MacaylaMarvelous81 commented 3 months ago

$APPDATA also is just for Windows and unrelated to the Minecraft installation so I feel like it runs into the same problem. Here's what happens if I check $APPDATA on my Debian computer:

jomarm@Dell-Inspiron-7773:~$ echo $APPDATA

jomarm@Dell-Inspiron-7773:~$
dxxxxy commented 3 months ago

Other than setting it manually, I see no other option.