Renaming does not work - Githubissues

dy-sh / obsidian-unique-attachments

Obsidian plugin. Renames attachments, making their names unique.

MIT License

45 stars 5 forks source link

Renaming does not work #3

Open jorgb opened 3 years ago

jorgb commented 3 years ago

Hi,

I tried running your plugin, besides the fact there was no popup message informing of the starting of the progress (first of all I thought it didn't do anything so I invoked it multiple times on accident), it seems to not pick up any attachments. The message I get after a minute or so, "there are no files to rename" while I have plenty of .png and .jpg files to rename.

Does it still work? Maybe something got broken with the obsidian 0.12.1 update?

Suggestions though..

Popup for warning before starting (although I backed up, I would hate to invoke it on accident)
Popup message that the plugin is in the process of renaming
Move all double files to .trash at least instead of deleting, so that there is recovery in de file meta data if symantically they mean different things.

I hope you can get your plugin sorted, I was contemplating about creating a similar plugin, but more on a file by file basis. This will do that trick too.

Jorgen

dy-sh commented 3 years ago

Thanks, I'll take a look.

dy-sh commented 3 years ago

I have version 0.11.13. This is the latest available version available on the site. I have no problem in it. You probably have an early access version. I have no way to download it.

jorgb commented 3 years ago

That is a shame. Is there any debug log I can enable to send to you? I counted in the attachments folder approx 100 files, and it would be weird if none of those got hashed or match something.

Jorgen

On Sat, 1 May 2021 at 12:59, Derwish @.***> wrote:

I have version 0.11.13. This is the latest available version available on the site. I have no problem in it. You probably have an early access version. I have no way to download it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/derwish-pro/obsidian-unique-attachments/issues/3#issuecomment-830612923, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA23JW4EN5DBLDGVS7IXZTLTLPNIZANCNFSM436FJEFA .

dy-sh commented 3 years ago

I have already downloaded the insider version and will see what the problem is.

dy-sh commented 3 years ago

Hello. I tested the 0.12.2 version and did not notice any problems. Could you send me a test vault showing the problem? I'll see what the problem might be in your case.

jorgb commented 3 years ago

Hi,

Here is a video explaining it. You can reproduce it on the help vault.

https://drive.google.com/file/d/1H3LxLsAT6Q1xBg13e2qtbVpOXok6rZlJ/view?usp=sharing

ps. the playback quality on Google Drive is poor. The MP4 file is 27Mb and downloaded it looks more crisp.