search

dyAmandys / aforge

Automatically exported from code.google.com/p/aforge
Other
0 stars 0 forks source link

Undocumented InvalidImagePropertiesException throw #218

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Given any image with a width of 1:

BlobCounter bc = new BlobCounter();
bc.ProcessImage(image);

will throw an InvalidImagePropertiesException, with the message "too small 
image". (BlobCounter.cs:137-138)

I was unable to find any documentation (other than the source itself) either 
that ProcessImage is capable of throwing such an exception, nor what image 
dimensions are permissible for BlobCounter.

My preferred fix is that BlobCounter be allowed to process images of width 1, 
but it appears this is not as simple as I had hoped.

An acceptable alternative would be to update the documentation. If you choose 
this option, the attached patch changes all three places I looked for 
documentation. I'm not sure if it's necessary/reasonable to change the 
BlobCounterBase docs, though.

Original issue reported on code.google.com by dales...@gmail.com on 11 May 2011 at 2:57

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by andrew.k...@gmail.com on 11 May 2011 at 3:02

GoogleCodeExporter commented 9 years ago 
Yep, documentation change is easier at this point. Otherwise we just need to 
implement custom Y-loop for 1 pixel side images.

Committed in revision 1475. Will be released in version 2.2.0.

Original comment by andrew.k...@gmail.com on 11 May 2011 at 3:15

GoogleCodeExporter commented 9 years ago

Original comment by andrew.k...@gmail.com on 28 Jul 2011 at 9:48

GoogleCodeExporter commented 9 years ago

Original comment by andrew.k...@gmail.com on 10 Aug 2011 at 9:36