henriquecarv commented 4 years ago

Changes

This Pull request aims to update our dependencies and transpose the implementations to typescript, using the appropriate interfaces from third-party libraries and our owns.

'limit' and 'order` capabilities have been added to the connector, along with automated tests.
mocha callback methods had to be updated with its latest implementations, but tests have been kept with the same structure to preserve previous consistency and assurance.

Relevant packages added/replaced/updated

firebase-admin: Replaced with @google-cloud/firestore which was included as a dependency of the former, this way saving on peer dependencies and reducing our package size.

Node version

Upgraded the minimum to >=10. LTS is currently at 12.

henriquecarv commented 4 years ago

🤔 This test also fails intermittently for me sometimes. Do you have any ideas about what can be the cause?

As you can see in this screenshot, it is passing as expected.

henriquecarv commented 4 years ago

It worked this time 👍

dyaa commented 4 years ago

I promise that I will check it next week since am on ✈️ mood

dyaa / loopback-connector-firestore

Migrating to typescript and latest packages #164

Changes

Relevant packages added/replaced/updated

Node version