search

dybarsky / spots-dialog

Android AlertDialog with moving dots progress indicator
MIT License
1.08k stars 242 forks source link

Minor issue with long texts #26

Closed FANMixco closed 6 years ago

FANMixco commented 7 years ago

I think your library is awesome :D! However, there is one minor improvement point:

<TextView
        android:id="@+id/dmax_spots_title"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_marginTop="@dimen/title_margin"
        android:layout_gravity="center"
        android:textAppearance="?attr/DialogTitleAppearance"
        android:text="?attr/DialogTitleText"/>

The layout_width should be match_parent, if it's wrap_content and the text is too long for X or Y reason, it stops working as expected and it goes to the left. Maybe you could update it in your free time! Thanks for so awesome library.

dybarsky commented 7 years ago

Hi, @FANMixco! Thanks for feedback and for suggestion. I'll check it out and make new build

dybarsky commented 6 years ago

Hi. I've checked and layout_width is already match_parent