dyc3 / opentogethertube

Watch videos with your friends. The spiritual successor to TogetherTube, preserving the spirit of it's simple to use interface, while improving it's look, feel, and reliability.
https://opentogethertube.com
GNU Affero General Public License v3.0
417 stars 56 forks source link

Remove white bars from Vimeo player #1061

Closed KennethSkelton closed 1 year ago

KennethSkelton commented 1 year ago

Is your feature request related to a problem? Please describe.

When playing a video from vimeo white bars are inserted into the player to conform the video to a specific aspect ratio.

This can be seen when playing this video: https://vimeo.com/28941097 and in https://vimeo.com/855564854

When the video is not wide enough, bars are inserted on the sides. when the video is too wide, bars are inserted on the top and bottom. Using the room in theater mode has no effect on this issue

Describe the solution you'd like

Either remove the bars, or find some way to turn the bars black, or find some way to match the bars to the room color theme.

Vimeo themselves solves this issue by having an ultra wide player and filling in the space on the left and right with black.

Additional context

Screenshot of the bars on ott

Screen Shot 2023-08-25 at 11 22 12 PM Screen Shot 2023-08-25 at 11 26 31 PM

corrosponding videos on vimeo

Screen Shot 2023-08-25 at 11 26 50 PM Screen Shot 2023-08-25 at 11 27 06 PM
dyc3 commented 1 year ago

So apparently, if the color scheme of the parent page is different from the color scheme of the iframe page, the iframe background will become opaque. Source: https://fvsch.com/transparent-iframes

I've filed 2 upstream issues related to this: