dyc3 / opentogethertube

Watch videos with your friends. The spiritual successor to TogetherTube, preserving the spirit of it's simple to use interface, while improving it's look, feel, and reliability.
https://opentogethertube.com
GNU Affero General Public License v3.0
413 stars 56 forks source link

client: minor refactors for RoomSettingsForm #1762

Closed dyc3 closed 5 months ago

dyc3 commented 5 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.8108%. Comparing base (ea69f9a) to head (a4a6356).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1762 +/- ## ================================================ + Coverage 62.7959% 62.8108% +0.0149% ================================================ Files 168 168 Lines 24879 24889 +10 Branches 1444 1444 ================================================ + Hits 15623 15633 +10 Misses 9203 9203 Partials 53 53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 5 months ago

Passing run #1954 ↗︎

0 84 1 0 Flakiness 0

Details:

Merge a4a635662dd163df0468366b860d0857ae645436 into ea69f9a6f471c5f5699913a41a1a...
Project: OpenTogetherTube Commit: 1111914eff ℹ️
Status: Passed Duration: 05:00 💡
Started: Apr 30, 2024 8:47 PM Ended: Apr 30, 2024 8:52 PM

Review all test suite changes for PR #1762 ↗︎

github-actions[bot] commented 5 months ago

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt   2024-04-30 20:48:39.418774522 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt   2024-04-30 20:48:40.210769164 +0000
@@ -30,7 +30,7 @@
 dist/assets/Attribution-hash.js                            0.34 kB │ gzip:   0.26 kB
 dist/assets/NotFound-hash.js                               0.60 kB │ gzip:   0.32 kB
 dist/assets/placeholder-hash.js                            1.04 kB │ gzip:   0.48 kB
-dist/assets/PasswordReset-hash.js                          2.00 kB │ gzip:   0.96 kB
+dist/assets/PasswordReset-hash.js                          2.00 kB │ gzip:   0.95 kB
 dist/assets/RoomList-hash.js                               2.31 kB │ gzip:   1.08 kB
 dist/assets/Privacy-hash.js                                2.64 kB │ gzip:   1.29 kB
 dist/assets/Home-hash.js                                   5.43 kB │ gzip:   1.34 kB
@@ -38,11 +38,11 @@
 dist/assets/de-hash.js                                    10.79 kB │ gzip:   4.49 kB
 dist/assets/fr-hash.js                                    11.59 kB │ gzip:   4.79 kB
 dist/assets/ru-hash.js                                    12.40 kB │ gzip:   6.42 kB
-dist/assets/es-hash.js                                    14.05 kB │ gzip:   5.98 kB
+dist/assets/es-hash.js                                    14.05 kB │ gzip:   5.97 kB
 dist/assets/PeertubePlayer-hash.js                        16.35 kB │ gzip:   5.54 kB
 dist/assets/VimeoPlayer-hash.js                           39.99 kB │ gzip:  12.52 kB
-dist/assets/Room-hash.js                                 161.82 kB │ gzip:  50.73 kB
+dist/assets/Room-hash.js                                 161.86 kB │ gzip:  50.78 kB
 dist/assets/GoogleDrivePlayer-hash.js                    604.87 kB │ gzip: 173.51 kB
 dist/assets/index-hash.js                                743.54 kB │ gzip: 248.18 kB
 dist/assets/PlyrPlayer-hash.js                         1,280.78 kB │ gzip: 379.37 kB
-✓ built in 25.92s
+✓ built in 25.98s
cypress[bot] commented 5 months ago

Passing run #1957 ↗︎

0 84 1 0 Flakiness 0

Details:

client: minor refactors for RoomSettingsForm (#1762)
Project: OpenTogetherTube Commit: cf03f77436
Status: Passed Duration: 04:56 💡
Started: Apr 30, 2024 10:22 PM Ended: Apr 30, 2024 10:27 PM

Review all test suite changes for PR #1762 ↗︎