search

dyc3 / opentogethertube

Watch videos with your friends. The spiritual successor to TogetherTube, preserving the spirit of it's simple to use interface, while improving it's look, feel, and reliability.
https://opentogethertube.com
GNU Affero General Public License v3.0
413 stars 56 forks source link

client: move chat outside of youtube player bounds to comply with youtube TOS #1791

Closed dyc3 closed 1 month ago

dyc3 commented 1 month ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dyc3 and the rest of your teammates on Graphite Graphite

github-actions[bot] commented 1 month ago

Bundle size diff

diff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt   2024-08-22 22:10:47.151694722 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt   2024-08-22 22:10:47.739693032 +0000
@@ -24,7 +24,7 @@
 dist/assets/YoutubePlayer-hash.css                         0.15 kB │ gzip:   0.14 kB
 dist/assets/RoomList-hash.css                              0.31 kB │ gzip:   0.22 kB
 dist/assets/Home-hash.css                                  0.93 kB │ gzip:   0.39 kB
-dist/assets/Room-hash.css                                 12.25 kB │ gzip:   2.93 kB
+dist/assets/Room-hash.css                                 12.55 kB │ gzip:   2.97 kB
 dist/assets/PlyrPlayer-hash.css                           30.56 kB │ gzip:   4.79 kB
 dist/assets/index-hash.css                               367.61 kB │ gzip:  58.53 kB
 dist/assets/pirate-hash.js                                 0.32 kB │ gzip:   0.25 kB
@@ -37,14 +37,14 @@
 dist/assets/Home-hash.js                                   5.48 kB │ gzip:   1.38 kB
 dist/assets/YoutubePlayer-hash.js                          5.86 kB │ gzip:   2.22 kB
 dist/assets/de-hash.js                                    10.79 kB │ gzip:   4.49 kB
-dist/assets/fr-hash.js                                    11.59 kB │ gzip:   4.79 kB
-dist/assets/ru-hash.js                                    13.57 kB │ gzip:   6.95 kB
+dist/assets/fr-hash.js                                    11.59 kB │ gzip:   4.78 kB
+dist/assets/ru-hash.js                                    13.57 kB │ gzip:   6.94 kB
 dist/assets/pt-hash.js                                 13.81 kB │ gzip:   5.87 kB
-dist/assets/es-hash.js                                    14.05 kB │ gzip:   5.98 kB
+dist/assets/es-hash.js                                    14.05 kB │ gzip:   5.97 kB
 dist/assets/PeertubePlayer-hash.js                        16.35 kB │ gzip:   5.54 kB
-dist/assets/VimeoPlayer-hash.js                           39.99 kB │ gzip:  12.53 kB
-dist/assets/Room-hash.js                                 164.21 kB │ gzip:  51.46 kB
+dist/assets/VimeoPlayer-hash.js                           39.99 kB │ gzip:  12.52 kB
+dist/assets/Room-hash.js                                 164.27 kB │ gzip:  51.49 kB
 dist/assets/GoogleDrivePlayer-hash.js                    604.87 kB │ gzip: 173.51 kB
 dist/assets/index-hash.js                                743.90 kB │ gzip: 248.30 kB
-dist/assets/PlyrPlayer-hash.js                         1,280.78 kB │ gzip: 379.37 kB
-✓ built in 25.62s
+dist/assets/PlyrPlayer-hash.js                         1,280.78 kB │ gzip: 379.36 kB
+✓ built in 25.34s
cypress[bot] commented 1 month ago

OpenTogetherTube    Run #2003

Run Properties:  status check failed Failed #2003  •  git commit e35a935870 ℹ️: Merge 3212d0aeb1e7434b31a30e397b64d608cda8b7cb into 69c7897d25e8382eaea99f7eb1c1...
Project OpenTogetherTube
Branch Review 08-22-client_move_chat_outside_of_youtube_player_bounds_to_comply_with_youtube_tos
Run status status check failed Failed #2003
Run duration 05m 37s
Commit git commit e35a935870 ℹ️: Merge 3212d0aeb1e7434b31a30e397b64d608cda8b7cb into 69c7897d25e8382eaea99f7eb1c1...
Committer Carson McManus
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron View Output
Test Artifacts
Video playback > should add and play a youtube video Test Replay Screenshots
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.6003%. Comparing base (69c7897) to head (3212d0a). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1791 +/- ## ================================================ + Coverage 61.5656% 61.6003% +0.0346% ================================================ Files 169 169 Lines 25472 25495 +23 Branches 1447 1447 ================================================ + Hits 15682 15705 +23 Misses 9736 9736 Partials 54 54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dyc3 commented 1 month ago

Merge activity

cypress[bot] commented 1 month ago

OpenTogetherTube    Run #2004

Run Properties:  status check failed Failed #2004  •  git commit 7b10e86a37: client: move chat outside of youtube player bounds to comply with youtube TOS (#...
Project OpenTogetherTube
Branch Review master
Run status status check failed Failed #2004
Run duration 06m 01s
Commit git commit 7b10e86a37: client: move chat outside of youtube player bounds to comply with youtube TOS (#...
Committer Carson McManus
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 83
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/e2e/integration/playback.spec.ts • 1 failed test • E2E - electron View Output
Test Artifacts
Video playback > should add and play a youtube video Test Replay Screenshots