dydxprotocol / v4-chain

dydx v4 protocol
Other
205 stars 85 forks source link

[TRA-451] initialize vaults on start-up in local, dev, staging #1782

Closed tqin7 closed 6 days ago

tqin7 commented 1 week ago

Changelist

initialize vaults on start-up

can easily extend to more/fewer vaults

Test Plan

tested by running localnet

Author/Reviewer Checklist

Summary by CodeRabbit

linear[bot] commented 1 week ago

TRA-451 initialize vaults in staging on startup

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes primarily revolve around updating various scripts related to the blockchain genesis file configuration. Key updates include modifications to the edit_genesis function calls across different scripts to improve handling of accounts and vault numbers, and initialization statuses. These adjustments ensure consistency and add new functionalities for handling vault accounts and numbers.

Changes

File Change Summary
protocol/scripts/genesis/prod_pregenesis.sh Reordered arguments in edit_genesis function call to shift the exchange config directory.
protocol/testing/containertest/containertest.sh and protocol/testing/e2etest-local/local.sh Added an extra empty string argument in edit_genesis function call within create_validators function.
protocol/testing/genesis.sh Added functionality for handling vault accounts and numbers; updated edit_genesis parameters.
protocol/testing/testnet-dev/dev.sh Added additional vault addresses and numbers to be used in edit_genesis function.
protocol/testing/testnet-local/local.sh Included BTC and ETH vault addresses and numbers; modified edit_genesis function to incorporate vault accounts and numbers.
protocol/testing/testnet-staging/staging.sh Introduced various vault accounts (BTC, ETH, LINK, MATIC, CRV) and their IDs; updated edit_genesis function parameters.

Sequence Diagram(s)

sequenceDiagram
    participant Script as Script
    participant Function as edit_genesis
    participant Config as Genesis Config

    Script->>Function: edit_genesis("$VAL_CONFIG_DIR", ... , "${VAULT_ACCOUNTS[*]}", "${VAULT_NUMBERS[*]}", ...)
    Function->>Config: Initialize Genesis Config
    Config-->>Function: Genesis Config with Vault Accounts & Numbers
    Function-->>Script: Updated Genesis Configuration

Poem

On cryptic blocks of chain we tread,
With vaults of numbers in our stead.
Genesis scripts align just right,
To guide us through the dark of night.
From BTC to ETH, a boundless quest,
Our genesis files now truly blessed. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.