Closed shrenujb closed 6 days ago
[!WARNING]
Rate limit exceeded
@shrenujb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 30 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between a7dc56e075e1b97633973e2dd0221769894f14b1 and 5b23266636c3a12710f14c8ae09f6d3921b551d3.
The recent updates enhance the App
struct's setupUpgradeHandlers
function by including RevShareKeeper
and PricesKeeper
parameters. These changes facilitate initializing the revenue share module and setting market mapper revenue share parameters and details. The modifications also extend the capabilities of the upgrade system and introduce new tests to validate post-upgrade conditions effectively.
Files | Summary |
---|---|
protocol/app/upgrades.go |
The setupUpgradeHandlers function now includes RevShareKeeper and PricesKeeper . |
protocol/app/upgrades/v6.0.0/upgrade.go |
Added functions to initialize rev share module state and include new parameters in CreateUpgradeHandler . |
protocol/app/upgrades/v6.0.0/upgrade_container_test.go |
Introduced postUpgradeMarketMapperRevShareChecks and added necessary imports. |
protocol/x/revshare/types/types.go |
Introduced the RevShareKeeper interface for handling market revenue share parameters and details. |
sequenceDiagram
participant App
participant ModuleManager
participant Configurator
participant ClobKeeper
participant RevShareKeeper
participant PricesKeeper
App->>ModuleManager: Initialize modules
App->>Configurator: Set configurations
App->>ClobKeeper: Manage clob operations
App->>RevShareKeeper: Include rev share parameters
App->>PricesKeeper: Include price parameters
RevShareKeeper->>Market: Set revenue share parameters
PricesKeeper->>Market: Set market price details
In lines of code, new paths will find, RevShare and Prices now aligned. A clever tweak, a graceful infusion, Modules dance in sweet inclusion. Upgrade handlers, set with care, Lift our app up, data to share.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Changelist
Add initialization for the x/revshare module chain state in the v6 upgrade handler Add upgrade test
Test Plan
Added test
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
New Features
Tests