[CT-970] Add debug logs to roundtable task, fix case where marketId!=perpetualId

dydxwill commented 6 days ago

Changelist

calculateEquity function was failing when marketId!=perpetualId, as is the case for dydx (perpetualId=63, marketId=1000001)

Test Plan

Tested in e2e env.

Author/Reviewer Checklist

[ ] If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
[ ] If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
[ ] If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
[ ] If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
[ ] If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
[ ] Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

New Features
- Added support for a new branch to trigger workflows in the mainnet.
Bug Fixes
- Improved test cases to handle scenarios with missing prices and mismatches between perpetualId and marketId.
Logging Enhancements
- Introduced detailed logging to track account/subaccount information and errors during PNL tick creation and equity calculation.
Performance Improvements
- Enhanced market and perpetual market updates during equity calculations for better accuracy.

coderabbitai[bot] commented 6 days ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

This update introduces significant enhancements and new test scenarios for the PNL tick creation and calculation logic. It includes additional logging to track key details, error conditions, and significant changes in equity or total PNL. The changes also ensure the workflow triggers for a new branch, 'wl/pnldbg2', alongside other branches.

Changes

Files	Change Summaries
`.github/workflows/indexer-build-and-push-mainnet.yml`	Added `'wl/pnldbg2'` branch to trigger workflow along with existing branches.
`indexer/services/roundtable/__tests__/helpers/pnl-ticks-helper.test.ts`	Added new test cases for missing price scenario and perpetualId/marketId mismatch in `calculateEquity`.
`indexer/services/roundtable/src/helpers/pnl-ticks-helper.ts`	Added detailed logging for tracking PNL tick creation and calculation of equity and total PNL.
`indexer/services/roundtable/src/tasks/create-pnl-ticks.ts`	Imported `perpetualMarketRefresher` and added call to `updatePerpetualMarkets()` in `runTask` function.

Poem

Amidst the code where numbers dance,
We've given equity a fighting chance.
Logs now track each tick and tale,
To ensure our PNL won't derail.
So here's a cheer, a code delight,
For branches new and tests so bright! 🌟 👾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

linear[bot] commented 6 days ago

CT-970 pnl doesn't get created in mainnet for certain subaccounts

dydxwill commented 6 days ago

@mergifyio backport release/indexer/v5.x

mergify[bot] commented 6 days ago

backport release/indexer/v5.x

✅ Backports have been created

* [#1795 [CT-970] Add debug logs to roundtable task, fix case where marketId!=perpetualId (backport #1786)](https://github.com/dydxprotocol/v4-chain/pull/1795) has been created for branch `release/indexer/v5.x`

dydxprotocol / v4-chain