Closed mergify[bot] closed 6 days ago
Cherry-pick of 87a919e67b490b0ff469083120af95a16f3a0a90 has failed:
On branch mergify/bp/release/protocol/v5.1.x/pr-1678
Your branch is up to date with 'origin/release/protocol/v5.1.x'.
You are currently cherry-picking commit 87a919e6.
(fix conflicts and run "git cherry-pick --continue")
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)
Changes to be committed:
modified: protocol/daemons/liquidation/client/sub_task_runner.go
modified: protocol/x/perpetuals/keeper/perpetual_test.go
new file: protocol/x/perpetuals/lib/lib.go
new file: protocol/x/perpetuals/lib/lib_test.go
modified: protocol/x/subaccounts/keeper/subaccount.go
Unmerged paths:
(use "git add <file>..." to mark resolution)
both modified: protocol/x/perpetuals/keeper/perpetual.go
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
[!IMPORTANT]
Review skipped
Bot user detected.
To trigger a single review, invoke the
@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Changelist
Move
x/perpetuals/keeper/perpetual.go
helper functions tox/perpeptuals/lib
for clarity. This is the first step in refactoring some of the margining functions for performance.Test Plan
Summary by CodeRabbit
Refactor
Tests
Style
This is an automatic backport of pull request #1678 done by Mergify.