coderabbitai[bot]
commented
3 weeks ago Walkthrough
The changes in this pull request involve modifications to several files, primarily focusing on enhancing the functionality and performance of the funding index updates retrieval process. Key updates include the addition of a maximum height variable in the SQL query logic, a new configuration parameter for vault settings, improved logging and performance measurement in the vault controller, and the introduction of methods for efficient data retrieval. These changes collectively refine the data handling and observability of the vault-related operations.
Changes
| File Path | Change Summary |
|---|---|
indexer/packages/postgres/src/stores/funding-index-updates-table.ts |
Added variable maxheight in findFundingIndexMaps to limit effectiveAtHeight in SQL query. |
indexer/services/comlink/src/config.ts |
Introduced new config parameter VAULT_FETCH_FUNDING_INDEX_BLOCK_WINDOWS with default value 250,000. |
indexer/services/comlink/src/controllers/api/v4/vault-controller.ts |
Added logging and timing for operations, introduced getFundingIndexMapsChunked, and added getHeightWindows. |
Possibly related PRs
- #2475: Enhances the performance of the vault endpoint by modifying how funding index update maps are fetched, directly related to
findFundingIndexMaps. - #2403: Introduces a filtering function for PnL ticks and modifies the handling of resolution parameters, which connects to the changes made in the
findFundingIndexMapsfunction regarding how data is processed and retrieved. - #2364: The transition from using placeholder configuration flags to fetching vaults directly from the database in this PR relates to the overall improvements in data handling and retrieval logic seen in the main PR.
- #2376: Enhancements to the functionality related to the main subaccount's PnL calculations in this PR align with the changes made to the
findFundingIndexMapsfunction, as both involve refining how data is processed and utilized. - #2454: The addition of a function to retrieve the latest hourly PnL tick in this PR complements the changes in the main PR, which also focuses on refining data retrieval and processing logic.
- #2446: This PR addresses issues with PnL aggregation, which is relevant to the changes made in the main PR regarding the logic for determining which records to include in results.
- #2485: Fixing test flakiness due to inconsistent time usage in this PR relates to ensuring the reliability of the data being processed in the main PR, particularly in how the
findFundingIndexMapsfunction operates.
Suggested labels
backport/indexer/v7.x
Suggested reviewers
- shrenujb
- tqin7
Poem
In the fields where numbers play,
A max height leads the way.
Configs grow, and logs will sing,
Fetching funds, a joyful thing!
With each update, we refine,
Hopping forward, all align! 🐇✨
vincentwschau
mergify[bot]
Changelist
Chunk the funding index maps to get for each vault subaccount to reduce the amount of rows scanned. Heights to get funding index maps for will be separated into chunks that cover 250k blocks each (number of blocks per chunk can be configured). Updated funding index map query to limit searches to both a min and max block height.
Additional fixes:
Test Plan
Existing unit tests.
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
New Features
Improvements