Revisions for setting up a full node

dydxprotocol / v4-documentation

https://v4-teacher.vercel.app

Other

12 stars 34 forks source link

Revisions for setting up a full node #232

Closed zachfc closed 2 months ago

zachfc commented 3 months ago

Site: https://docs.dydx.exchange/infrastructure_providers-validators/how_to_set_up_full_node GitHub: https://github.com/dydxprotocol/v4-documentation/blob/main/pages/infrastructure_providers-validators/how_to_set_up_full_node.md

Revising this page for clarity -- since I've been here there's been some confusion from customers about this and the following topic, Running a Full Node. This rewrite:

adds some context to each procedure
reorganizes content (especially procedure steps) for flow
attempts to make examples more digestible
rewords anything that could be ambiguous

I called out a couple places to check for accuracy in particular, but really the whole thing needs to be vetted by an engineer. If something is even a little confusing/ seems off to you, please call it out

vercel[bot] commented 3 months ago

Someone is attempting to deploy a commit to the dYdX Trading Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-teacher	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2024 3:26pm

zachfc commented 2 months ago

Hey @ttl33, could you take another look at this whenever you have time? Implemented most of your suggestions -- the things I have not addressed:

I left a comment on 2 things that I think we should not add (PATH and IP info)
I'll need to find out about that REST endpoint/ other way to get the live chain version. The callouts are there, will just need to add more detail in the step

Also, I'll use this PR to merge: https://github.com/dydxprotocol/v4-documentation/pull/236 Signed my commits on that one, this one is unverified

zachfc commented 2 months ago

Hey @ttl33, I've made most of these updates as well. However, Mohammed let me know that he pushed significant updates to this page today -- it includes a ton of good info that I don't have, so I'm now incorporating these additions in my docs. I'll push up a pretty new/reworked page in this PR: https://github.com/dydxprotocol/v4-documentation/pull/236

zachfc commented 2 months ago

Closing this PR, comments will be addressed in a rewrite of this page, PR #241