do not render svgs - Githubissues

dydxprotocol / v4-native-ios

Other

1 stars 0 forks source link

do not render svgs #185

Closed mike-dydx closed 4 months ago

mike-dydx commented 4 months ago

Links (dYdX Internal Use Only)

Crash Report - https://console.firebase.google.com/project/dydx-operations-services/crashlytics/app/ios:trade.dydx/issues/ecc9ca49112490f323ba62e63908198d?time=last-seven-days&types=crash&sessionEventKey=d7a215e7745b418494ca33ea98893fc2_1955421581287272308

Description / Intuition

fixes crash on deposit asset selection screen
squid provides some source/token icons as svgs which degrades performance. Either they are bad SVGs or SwiftUI is just not super compabitible with SVGs
have asked squid to replace SVGs with PNGs as well
removes trading rewards feature flag
fixes trading rewards to properly set selected period

Before/After Screenshots or Videos

Before	After

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring or Technical Debt
[ ] Documentation update
[ ] Other (please describe: )