search

dydxprotocol / v4-web

Other
80 stars 67 forks source link

When entering price on QWERTZ NumBlock automagically change/replace "NumBlockComma" to "Fullstop" #330

Open Cyroex opened 8 months ago

Cyroex commented 8 months ago

On QWERTZ keyboards like mine there is a "," (comma) on the numblock but the price input field expects a dot "." (decimal point) For example: I want to buy DOGE at 200 dollar and 1 cent i enter: "200,01" which should be interpreted as "200.01".

Hope you know what i mean. Thank you.

rr9vqBVYHoGrF1v3crg8

linear[bot] commented 8 months ago

GH-14 When entering price on QWERTZ NumBlock automagically change/replace "NumBlockComma" to "Fullstop"

jaredvu commented 8 months ago

@Cyroex Thanks for flagging, I think that we can update to handle different decimal separators. Right now, the decimal and thousands separators are determined by locale.

jaredvu commented 7 months ago

@moo-onthelawn @aforaleka Do you think we should remove locale handling for these separators and instead have a settings menu to allow users to change to whichever number representation they want?

Cyroex commented 5 months ago

When i change the interface to "Deutsch" setting in the top menu it works as expected. But.. boy those translations are rough/confusing/sound like dumb AI/wrong/misleading

Side question: Is it possible to contribute to uk/us (english) -> de/at/ch (german) translation? (one way)

moo-onthelawn commented 5 months ago

hmm @jaredvu, that makes sense, but a bit concerned it would feel too hidden to be discoverable for most users (I feel like the preferences dialog isn't super used). Would be curious to dig into other number representation settings that we might want to configure - if this is the only one, I'm partial to updating number separator handling to be universal across languages ( i.e , and . are interpreted as separators in all languages)