chore: update order status notif to show average fill price when filled

dydxprotocol / v4-web

Other

74 stars 61 forks source link

chore: update order status notif to show average fill price when filled #921

Closed aforaleka closed 4 weeks ago

aforaleka commented 1 month ago

order updates don't have fill price info, so we need to calculate it ourselves abacus fill notif does the same calculation, so we're bringing it the order status notif

repro steps: place a limit order that cross an orderbook e.g. buy ETH at $5000, observe that the order should be filled at market price e.g. $2600 instead of $5000
followup: might want to add a field / replace existing price field on orders table, if so will do in a followup

linear[bot] commented 1 month ago

CT-1127 Update notification for limit orders that cross the spread

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 9:32pm
v4-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 14, 2024 9:32pm