feat: add buys and sells as marks on tv chart - Githubissues

dydxprotocol / v4-web

Other

74 stars 61 forks source link

feat: add buys and sells as marks on tv chart #927

Closed tinaszheng closed 3 weeks ago

tinaszheng commented 4 weeks ago

This PR adds Marks to the TradingView chart for historical buy and sell orders.

Adding supports_marks: true to the datafeed configuration will tell TV to query the new getMarks method
Implemented getMarks
Also did some minor cleanup in our custom css file by combining a bunch of duplicate toggle classnames into singular .toggle and .toggle-active

Testing plan

Create a bunch of orders and close them (or view a market for which you have a bunch of historic orders)
Verify that the buy/sell marks show up on the chart for the correct time interval
Verify that the text in the tooltip shows the correct size and average price

linear[bot] commented 4 weeks ago

CT-1055 Show buys/sells

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 19, 2024 7:42pm
v4-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 19, 2024 7:42pm