search

dydxprotocol / v4-web

Other
74 stars 61 forks source link

fix(ohlc): add in missing dep to useTradingView hook #929

Closed moo-onthelawn closed 3 weeks ago

moo-onthelawn commented 4 weeks ago

ohlc was a little buggy (sometimes the toggle had to be clicked twice, or the toggle on was a few seconds delayed). Narrowed it down to a missing dep in useTradingView (adding tvWidgetRef to make sure toggle refs are set at appropriate times). That hook is still missing a lot of deps but I think a good number of them are intentional, so not otherwise touching

testing:

just toggling ohlc on/off a million times and verifying there's no delay

vercel[bot] commented 4 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 5:02pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 5:02pm
moo-onthelawn commented 3 weeks ago

closing for: https://github.com/dydxprotocol/v4-web/pull/933