fix(ohlc): fix toggle race condition

[moo-onthelawn]

Fix chart toggles sometimes not updating properly. s/o to Tina for narrowing it down to the initialization of the buttons being too far away (time wise) from the effects used to update them.

https://github.com/user-attachments/assets/ed607444-3b21-49b9-a021-1af5cfbf0890

Fix:

• Shift the effects into initialization of the buttons in useTradingView

Follow up to investigate doing this by hiding series, but deprioritizing for now given that this works*

Testing

• Toggle a million times, throttle internet

---

Constants/Types

• constants/charts
  • Add TOGGLE_ACTIVE_CLASS_NAME since it's used a bunch

Hooks

• hooks/useBuySellMarks, hooks/useChartLines, hooks/useOrderbookCandles

  • Move out logic for initializing onClick into useTradingView

• hooks/useTradingView

  • Move in logic for initializing onClick for toggles, and conditionally add active class name based on passed through state

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 19, 2024 9:57pm
v4-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 19, 2024 9:57pm