search

dyedgreen / deno-sqlite

Deno SQLite module
https://deno.land/x/sqlite
MIT License
409 stars 36 forks source link

Change query API types to better reflect expectations #113

Closed dyedgreen closed 3 years ago

dyedgreen commented 3 years ago

Currently, the type signature of query looks like this:

function query(sql: string, values?: object | QueryParam[]): Rows {}

I think something like this would be better:

function query(sql: string, values?: Record<string, QueryParam> | QueryParam[]): Rows {}