dyedgreen / deno-sqlite

Deno SQLite module
https://deno.land/x/sqlite
MIT License
409 stars 36 forks source link

interface `PreparedQuery` is not exported #118

Closed MierenManz closed 3 years ago

MierenManz commented 3 years ago

PreparedQuery is a interface for prepared queries, but as of v2.4.0 it is not exported

I think it it a good idea for it to be exported in the mod.ts

dyedgreen commented 3 years ago

The type definitions are not exported from the top level mod.ts, but you should be able to import them quite easily from where they are defined:

import { DB } from "https://deno.land/x/sqlite/mod.ts";
import { PreparedQuery } from "https://deno.land/x/sqlite/src/db.ts";

But I agree that it could be cleaner to re-export them, since then users don’t have to depend on a specific folder structure which might change between versions.

MierenManz commented 3 years ago

should I make a pr so that PreparedQuery get's exported in mod.ts aswell?

dyedgreen commented 3 years ago

That would be amazing 🀩

I think we could also export the other public types in the api, when doing that:

dyedgreen commented 3 years ago

@MierenManz do you still want to make the PR? Otherwise I'll go ahead and make it myself πŸ˜…

MierenManz commented 3 years ago

Oh go ahead. I actually forgot about it πŸ˜“ Exams coming up so I'm mostly studying

dyedgreen commented 3 years ago

Sure, no worries. Good luck with your exams πŸ€