dyedgreen / deno-sqlite

Deno SQLite module
https://deno.land/x/sqlite
MIT License
409 stars 36 forks source link

Improved VFS test coverage #241

Open fabiospampinato opened 1 year ago

fabiospampinato commented 1 year ago

It looks like js_access, js_truncate and js_print are never actually called when running tests, imo they probably should, to make sure they aren't entirely broken.

The implementation looks correct to me, but more than 0 tests for them would probably be helpful in my opinion.