search

dyedgreen / deno-sqlite

Deno SQLite module
https://deno.land/x/sqlite
MIT License
409 stars 36 forks source link

Added toObjects to Rows #74

Closed halvardssm closed 4 years ago

halvardssm commented 4 years ago

fixes #71

@dyedgreen Here is a PR, let me know what you think 😄 The one thing I am not too sure about is the error catching on lines 153-160, would there be a neater way of dealing with this or should I just leave it as such?

dyedgreen commented 4 years ago

Thank you for the PR! Please bare with me as, I try to have a look through it some time tonight or tomorrow 😅

dyedgreen commented 4 years ago

Thank you for the PR! (And sorry for taking so long to get to reviewing it, I'm quite busy with work at the moment 😅) Let me know if there is anything in the review that isn't clear 😃

halvardssm commented 4 years ago

Thank you for the PR! (And sorry for taking so long to get to reviewing it, I'm quite busy with work at the moment 😅) Let me know if there is anything in the review that isn't clear 😃

No worries! I know the feeling of juggling a dousin of things at the same time 👍

tksilicon commented 4 years ago

I got this error which happens when the database is empty SqliteError: Unable to retrieve column names as transaction is finalized.Seems @halvardssm solved it with this pull request and is waiting for @dyedgreen to merge. I am using this lib for DSO.

halvardssm commented 4 years ago

lgtm 😍

Let me merge this tomorrow, when I'm less sleepy 😴

(and thanks for bearing with me through the slow reviews)

No worries, I haven't had too much time lately myself (I guess this is the curse of open source) 😄

Thanks for the pointers regarding implementing the iterator! 💪🏻