Fix issue with databases > 2GB

dyedgreen / deno-sqlite

Deno SQLite module

https://deno.land/x/sqlite

MIT License

409 stars 36 forks source link

Fix issue with databases > 2GB #94

Closed dyedgreen closed 3 years ago

dyedgreen commented 3 years ago

Closes #92

This should fix the issues that are currently experienced if trying to use a database larger than i32::MAX bytes. Still need to figure out a good way to test this in CI (having a >2BG db file in CI is a bit tricky...)

dyedgreen commented 3 years ago

I tested this fix locally with a ~3.5GB database, could you check it addresses the issue you're seeing (#92) as well @chanibal?

chanibal commented 3 years ago

I was able to insert a few megabytes of data to a 7.7GB database, so it looks like this pull request does close #92. Thank you for the fix.

dyedgreen commented 3 years ago

I have no idea on how to approve this request. Marked all files as viewed, set "approve", clicked "submit review" and it still asks me for approval for merging.

Don't worry, I have to approve it 😉

I'll look over it again tomorrow to make sure I didn't make any funny typos, and merge it then 😄