search

dyedurham / SbManager

Installable web ui for managing Azure/Windows Service Bus
Apache License 2.0
31 stars 16 forks source link

Rationalise AngularJS Directives #1

Open lukeschafer opened 9 years ago

lukeschafer commented 9 years ago

The angular controllers/directives can be componentised better, with more thought put towards correct scope. It may also be worthwhile breaking out of the single epic directives.js file.

drewfreyling commented 8 years ago

I was thinking of starting this next but wanted to check with @jafin because it sounds like you may have made a start on this?

jafin commented 8 years ago

@drewfreyling I didn't do much in regard to the above, my branch was more about angular 1.4 which is in my repo and probably won't merge at the moment anyhow. So go for it.

lukeschafer commented 8 years ago

For the record, 'everything's a directive' is a great approach to controller design.

Yeah, this job probably needs to be done soon if you're looking to do more enhancements.