search

dyedurham / SbManager

Installable web ui for managing Azure/Windows Service Bus
Apache License 2.0
31 stars 16 forks source link

Add a filter to the overview screen to show only the topics and queues with deadletters #79

Closed crejb closed 7 years ago

crejb commented 7 years ago

Add a filter to the overview screen to show only the topics and queues with deadletters sbmanager filter 1 sbmanager filter 2

drewfreyling commented 7 years ago

@AmosC @rovens @zhangyiping What do you guys think about this PR?

lukeschafer commented 7 years ago

My 2c:

Great idea for a feature. Perhaps instead of using extra real estate you can incorporate it into the UI, along the lines of:

image

And for the toggle, a checkbox in the fixed footer, maybe on the right?

drewfreyling commented 7 years ago

Thanks @lukeschafer. I think that might be a bit of a better user experience along the lines of that. What do you think @crejb?

jonyeezs commented 7 years ago

I like the idea of the totals closer to the column.

For filter, I don't mind it being top. But some sort visible input should be associated, ie a checkbox.

lukeschafer commented 7 years ago

Yeah sure, it's certainly not bad to have it where you put it, but 2 things to think about are:

  1. Introducing a new paradigm for one feature, where a similar paradigm (actions that interact with the page) already exists
  2. Vertical realestate. Most places have tons of queues/topics, so vertical realestate is at a premium. A checkbox by itself could only take about 20 pixes, but to make it look good and flow well you need padding, margins, maybe a header etc. That all adds up.

I'm just a sideline observer though ;)

crejb commented 7 years ago

@drewfreyling good call on ng-pluralize, thanks

@lukeschafer the totals in the column header looks great. Regarding vertical space, I definitely agree it is at a premium. In a way, the whole purpose for this feature request is to target this by reducing the need to scroll down through the massive number of queues/topics to find the few with deadletters. Personally this is the only use case I ever have for SBManager but I can see it would be an interruption for other use cases.

I created a new story to put the totals in the column headers (https://github.com/GlobalX/SbManager/issues/80) so we can focus on the filter here. I'll have another think about a more concise way to show the filter. @jonyeezs lets chat about your checkbox idea.

jonyeezs commented 7 years ago

@jonyeezs lets chat about your checkbox idea.

Something along:

and maybe on top of the headers

drewfreyling commented 7 years ago

I also think we should add a route in for this as well so we can have it displayed on a monitor somewhere. Happy for that to be outside the scope of this PR.

jonyeezs commented 7 years ago

Let's just get this in.

LGTM!

drewfreyling commented 7 years ago

Closing because it is superseeded by #84