search

dyedurham / SbManager

Installable web ui for managing Azure/Windows Service Bus
Apache License 2.0
31 stars 16 forks source link

Status screen #83

Closed arthurs closed 6 years ago

arthurs commented 7 years ago

added a status dashboard designed to be statically displayed for monitoring purposes image

MitchellCash commented 7 years ago

@arthurs if approved, you should consider squashing those commits down before this gets merged

jonyeezs commented 6 years ago

@arthurs would you like to squash your commits before the merge, please

drewfreyling commented 6 years ago

We can squash them on merge?...

On Fri., 13 Oct. 2017, 4:25 pm Jonathan Yee, notifications@github.com wrote:

@arthurs https://github.com/arthurs would you like to squash your commits before the merge, please

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/GlobalX/SbManager/pull/83#issuecomment-336361913, or mute the thread https://github.com/notifications/unsubscribe-auth/ABF8Df9Qg6sPECs_ZHaein4N_3dDzNYJks5srwJVgaJpZM4N8EGa .

MitchellCash commented 6 years ago

Didn’t get in on time, but GitHub squash and merge is not as good as a rebase and squash locally because you can’t edit the commit message AFAIK.

GitHub just turns every commit message into a dot point in the commit description and sometimes this is a bit meaningless.