Less prominent 'Removal all' button and 'Deadletter all' should be a warning colored

AmosC commented 7 years ago

The following change:

Makes the 'Remove all' button smaller and separated from 'Requeue All' and 'Deadletter All'. This is so that the destructive operation is less likely to be clicked by accident. (It could be stated that there is a confirmation dialog to help prevent this, but as the dialog always appears for 'Requeue all', it can be easy to get into the habit of ignoring it)
Changes the css class of Deadletter all from btn-danger to btn-warning as deadlettering is not a destructive operation.

Before:

After:

AmosC commented 7 years ago

Not sure why, but the first commit swapped two lines, then the second swapped them back the right way. Fixed that by rebasing, the end result is the same as it was before

MitchellCash commented 7 years ago

While we are at it, what do we think of centering the buttons within the panel?

Center buttons

AmosC commented 7 years ago

The buttons are centered now as per suggestion

MitchellCash commented 7 years ago

LGTM 👍

dyedurham / SbManager

Less prominent 'Removal all' button and 'Deadletter all' should be a warning colored #86