search

dyedurham / SbManager

Installable web ui for managing Azure/Windows Service Bus
Apache License 2.0
31 stars 16 forks source link

[WIP] Switch to Microsoft.Azure.ServiceBus #91

Open 0xced opened 6 years ago

0xced commented 6 years ago

The Microsoft.Azure.ServiceBus package conforms to .NET Standard and thus works fine on Linux and macOS (using Mono). The WindowsAzure.ServiceBus package can't run on Mono since it depends on kernel32.dll.

Required incidental changes:

Note that this pull request is not ready to merge because of the local version of Mossharbor.AzureWorkArounds.ServiceBus which must be downloaded and compiled on its own.

drewfreyling commented 6 years ago

@0xced love the work you have done here. The downside of this is that it removes support of on premise Windows Service Bus. Having said that, WSB is dead so now should be the time we consider to drop support for it.

lukeschafer commented 6 years ago

You may as well tag/fork/whatever the last build that supports SBWS for anyone that cares and move on

On Wed, May 30, 2018 at 9:45 AM, Drew Freyling notifications@github.com wrote:

@0xced https://github.com/0xced love the work you have done here. The downside of this is that it removes support of on premise Windows Service Bus. Having said that, WSB is dead https://stackoverflow.com/a/38769190/122880 so now should be the time we consider to drop support for it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GlobalX/SbManager/pull/91#issuecomment-392983409, or mute the thread https://github.com/notifications/unsubscribe-auth/AA71rI4TXPDndxgVrysEtMx1G295kCOOks5t3d2FgaJpZM4USSA5 .

Mossharbor commented 6 years ago

@0xced Mossharbor.AzureWorkArounds.ServiceBus GetQueues and GetTopics should be available in version *.15 through nuget, thanks to your pull request.

0xced commented 6 years ago

Like #93, passing continuous integration testing would require to upgrade AppVeyor image to a more recent version of Visual Studio.

Current issue:

error CS0012: The type 'System.Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'netstandard, Version=2.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

0xced commented 6 years ago

Note: dependency on Mossharbor.AzureWorkArounds.ServiceBus can be removed now that Microsoft.Azure.ServiceBus 3.1.0 supports management operations, see https://github.com/Azure/azure-service-bus-dotnet/pull/481

drewfreyling commented 6 years ago

You may as well tag/fork/whatever the last build that supports SBWS for anyone that cares and move

@lukeschafer done - https://github.com/GlobalX/SbManager/tree/WSB

drewfreyling commented 5 years ago

Now that WSB is out of the way this PR can proceed.

0xced commented 5 years ago

Could you please update the AppVeyor configuration to use VS 2017 instead of VS 2015?