search

dyedurham / SbManager

Installable web ui for managing Azure/Windows Service Bus
Apache License 2.0
31 stars 16 forks source link

[Do not merge] Convert solution to the new csproj format #93

Open 0xced opened 6 years ago

0xced commented 6 years ago

Although the documentation (Additions to the csproj format for .NET Core) seems to imply that this is a .NET Core feature, it works with .NET Framework too and is much easier to maintain.

With this commit, the OctoPack feature is gone, it will need some work to reintegrate.

Note that this pull request depends on #91 to be merged first and should be rebased before merging.

0xced commented 6 years ago

The build failed with this error:

C:\projects\sbmanager\src\SbManager.Tests\SbManager.Tests.csproj(1,1): error MSB4041: The default XML namespace of the project must be the MSBuild XML namespace. If the project is authored in the MSBuild 2003 format, please add xmlns="http://schemas.microsoft.com/developer/msbuild/2003" to the element. If the project has been authored in the old 1.0 or 1.2 format, please convert it to MSBuild 2003 format.

So I tried to add an .appveyor.yml file to the repository for configuring the Visual Studio 2017 image but the same error occurred. I guess you have configured AppVeyor to ignore appveyor.yml. Could you please configure AppVeyor to use the Visual Studio 2017 image to verify that the build and the tests still succeed?

drewfreyling commented 5 years ago

Still need the pipeline changed for this PR? I was hesitant to initially but no direction has changed to make this azure only I'm happy to make the change?