search

dyedurham / SbManager

Installable web ui for managing Azure/Windows Service Bus
Apache License 2.0
31 stars 16 forks source link

Remove SignalR #95

Closed 0xced closed 6 years ago

0xced commented 6 years ago

Unless I missed something, SignalR seems not to be used at all in this project. My guess is that the SignalR setup code was copy-pasted from some OWIN startup sample code and never removed.

lukeschafer commented 6 years ago

There is an issue to start using it

On Thu, 31 May 2018, 11:21 pm Cédric Luthi, notifications@github.com wrote:

Unless I missed something, SignalR seems not to be used at all in this project. My guess is that the SignalR setup code was copy-pasted from some OWIN startup sample code and never removed.

You can view, comment on, or merge this pull request online at:

https://github.com/GlobalX/SbManager/pull/95 Commit Summary

  • Remove SignalR

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/GlobalX/SbManager/pull/95, or mute the thread https://github.com/notifications/unsubscribe-auth/AA71rI-d-MDjrNjzZdwV6h96FoxO6Yq0ks5t3-5TgaJpZM4UVCLZ .

0xced commented 6 years ago

Indeed, that’s #6. But in the meantime, having just a few lines of setup code adds nothing but confusion. (I spent a good amount of time wondering where SignalR was used only to realise that it was not!) When live updating with SignalR is implemented, re-adding the setup code won't be costly at all.