Open srghma opened 4 years ago
instead, it should have returned something like
# merges
query { avatar avatar }
# error, but should be possible
query {
countries { code }
countries(filter: { code: {eq: "AU"}}) { code }
}
(But there is no need to calculate hash for leaf without arguments. And they calculate same hash two times in two different places: build function and for decoder)
(Store decoders in SelectionSet
? This would also allow for fields with custom decoders)
button ::
∀ optionalGiven optionalMissing
. Prim.Row.Union optionalGiven optionalMissing (ButtonPropsOptions + MUI.Core.ButtonBase.ButtonBasePropsOptions + React.Basic.DOM.Props_button)
=> Record (MUI.Core.ButtonBase.ButtonBasePropsRequiredOptions + optionalGiven)
-> React.Basic.JSX
button = React.Basic.element _Button
Ability to make test requests that return expected string
HTTP.request
and Test.request
, HTTP.subscribe
and Test.subscribe
http://elm-graphql-normalize.herokuapp.com/
https://github.com/dillonkearns/elm-graphql/blob/master/ete_tests
Wow! I haven't taken a look at this in a while (life has a way of interrupting fun side-projects) but I'm extremely flattered you took enough interest to fork it and pick up the torch. When I wrote this I was still learning a lot about PS and particularly type-level programming so I'm very keen to dig into what you've done and your take on things.
I will update the readme to point to the fork.
my take is very much similar to elm-graphql) tnx)
I will list here what I found is missing:
IIUC elm-graphql doesnt stringify
FragmentSelectionSet
tofragment XXX { ... }
, but converts their content toSelectionSet
(though it could be an optimization to reduce size of query if fragment is used in several places. i.e. collect all fragments, give them unique name based on hash of content and paste at the top of the query)
subscriptions
generate types from:
exportJsonSchemaPath
optionexportGqlSchemaPath
option(they use graphql npm package for this)
https://github.com/dillonkearns/elm-graphql/blob/29727cf286f043ec87e942edbcd6a49aa3d5e409/generator/src/elm-graphql.ts#L65
https://github.com/dillonkearns/elm-graphql/blob/29727cf286f043ec87e942edbcd6a49aa3d5e409/generator/src/cli/generated-code-handler.ts#L46
https://github.com/dyerw/purescript-fernet/blob/7f747d726cee420e34419d317f9f810fd5ffcd2e/src/graphql/SelectionSet.purs#L25
https://github.com/dyerw/purescript-fernet/blob/7f747d726cee420e34419d317f9f810fd5ffcd2e/src/graphql/SelectionSet.purs#L38-L61
User contains tweet, tweet contains user?
What else is missing?