search

dyhli / bot-tf-issues

Issue tracker for Bot.tf
3 stars 0 forks source link

Sell-Only Banking makes bot decline "that item" offers #78

Closed p1415 closed 5 years ago

p1415 commented 5 years ago

Expected behavior

Let me manually review any item offer as expected.

Current behavior

When receiving Item Offer the bot incorrectly treats my Sell-Only Banking as both-ways full Item Banking but with Buy Price set to 0.

Possible solution

Treat a Sell-Only Banking as Sell Only. Maybe create a separate page for Sell-Only Banking instead of "Leave the buy price empty if you only want to sell" thing.

Steps to reproduce

  1. Open /config/banking and add an item leaving Buy Price empty.
  2. Wait for the bot to receive an Item Offer with this item.
  3. Watch the bot decline (INVALID_VALUE) claiming that "value on the user's side of the trade is N/A"

Detailed description

Related to issue #63 as Autopricer has the same bug treating "0" as a valid price.