dyindude / ubuntu-zfs

BSD 2-Clause "Simplified" License
8 stars 4 forks source link

align data partitions on 4k sectors #37

Closed dyindude closed 6 years ago

dyindude commented 6 years ago

When using LUKS, no partitions get created Consider adding a feature that creates a partition table on the disks prior to luksFormat: https://andrewmemory.wordpress.com/2015/04/12/setting-up-a-wd-red-drive-for-use-in-a-nas/

current build is giving partition alignment errors on disks, need to rule this out before calling it a firmware issue on the controller

dyindude commented 6 years ago

in my experimentation on real hardware, a good value for sgdisk is -a8, which I have set as the default value for data partitions in 6f320520a58eada2f31ff5421a0b8b18d082a968

root disks still use -a1, but we create the first partition at 2048 bytes, so it's "probably" fine for now (not as large of an issue with SSDs as it is with the WD reds)

dyindude commented 6 years ago

per http://open-zfs.org/wiki/Performance_tuning#Whole_Disks_versus_Partitions zfs should be smart enough to figure this out on its own, setting the scheduler etc when we give it full disks

the issues I was getting ended up being due to a buggy firmware on my HBA card, so I may run some tests with real hardware without the data volume partitions to make sure my real-world speeds are still where I want them to be (and no other errors crop up)