search

dylan-hackers / mindy

Mindy - minimal compiler-interpreter for Dylan
Other
21 stars 9 forks source link

[windows] Use PeekConsoleInput for input detection instead of ReadFile. #74

Closed phongphan closed 8 years ago

phongphan commented 8 years ago

Hi

This should fixed Error 122 when starting mindy debugger on Windows.

waywardmonkeys commented 8 years ago

This seems like a great fix for the standard input stream.

Unfortunately, setup_input_checker is also called in the course of fd_exec and I am not sure that this would be valid in that scenario.

I sort of feel like a lot of this is more complicated than it needs to be, but fixing it well probably means a lot more changes.

Is this change safe for the case of fd_exec or can it be made to be so?

phongphan commented 8 years ago

Thanks. I wasn't aware of it. I'll check and update later.

edited: Yes, you're right. It doesn't work with fd_exec. It does required a lot more changes.