search

dylan-lang / dylan-emacs-support

Emacs mode for indenting and highlighting Dylan code
GNU General Public License v2.0
27 stars 8 forks source link

Splitting the MELPA package into two packages #53

Closed lassik closed 3 years ago

lassik commented 3 years ago

Currently we have two sets of files: dylan-*.el and dime-*.el. There seems to be a somewhat clean separation between Dime and the other Dylan stuff. The Dime stuff depends on the Dylan stuff, but the Dylan stuff can also be used standalone.

In light of this division, I think we should split into two different Melpa packages: dylan and dime, with dylan as a dependency for dime. Both package names are available so there is no conflict with existing packages.

We can still keep both packages in the same git repo. A Melpa recipe can be written to only pick files matching a shell glob from a repo.

pedro-w commented 3 years ago

I see that would work, but is there a benefit to doing it?

lassik commented 3 years ago

The filename and symbol prefixes would match the package name, which is the usual convention. The dylan-mode package was added to Melpa early, back when they didn't yet do much in the way of code review, so it doesn't currently observe this convention.

lassik commented 3 years ago

I continue to advocate for the dylan/dime split as per MELPA conventions. Since most of our work is done, now would be a good time to send the requisite PRs to them.

cgay commented 3 years ago

This works for me.

Only tangentially related, it has occurred to me several times that this repo would be better named "dylan-emacs-support" or similar. No need to do that now though.

lassik commented 3 years ago

You could simply rename it to dylan-lang/emacs. When you do a rename, GitHub keeps the old URLs working as redirects (both HTTP and Git URLs), so it's no big deal.

lassik commented 3 years ago

@housel Any opinion on the MELPA package splitting and repo renaming?

housel commented 3 years ago

Sure, I'm fine with that.

lassik commented 3 years ago

@cgay Can you rename the repo? I can send the pull request to MELPA.

cgay commented 3 years ago

Done. I went with dylan-emacs-support.

lassik commented 3 years ago

This is now done, dylan and dime packages are up on MELPA. Please try uninstalling dylan-mode, installing the new packages, and open new issues for any problems you encounter (we made a lot of changes so there are sure to be a few).

lassik commented 3 years ago

For reference, the PR was https://github.com/melpa/melpa/pull/7483