search

dylan-lang / dylan-emacs-support

Emacs mode for indenting and highlighting Dylan code
GNU General Public License v2.0
27 stars 8 forks source link

Patches #59

Closed lassik closed 3 years ago

lassik commented 3 years ago

A couple more things.

lassik commented 3 years ago

@housel OK?

housel commented 3 years ago

I was waiting to see if the issues in #60 would be addressed.

lassik commented 3 years ago

The above fix should do it, but I haven't tested.

pedro-w commented 3 years ago

On my Emacs 27.1 I still get these warnings in the Compile-Log

Compiling file /Users/peterhull/Projects/dylan-mode/dime-repl.el at Sun Mar 28 11:35:58 2021
dime-repl.el:1487:7:Warning: assignment to free variable
    ‘dime-output-target-to-marker-function’
dime-repl.el:1488:7:Warning: assignment to free variable
    ‘dime-write-string-function’

In end of data:
dime-repl.el:1496:1:Warning: the function ‘dime-emit-to-target’ is not known
    to be defined.

But the errors I reported in #60 seem to be fixed by this last commit, thanks!

It would be good to address those warnings if it's possible, but not critical I suppose (AFAICS a lot of melpa packages throw up warnings when they're compiled)

lassik commented 3 years ago

Not sure what's going on. I don't get compiler warnings on 27.1. Did you try restarting Emacs and recompiling the .el files?

pedro-w commented 3 years ago

I did a (byte-recompile-directory "." 0 t) but I will redo it more carefully with a clean start and check I'm not picking up any old files from somewhere.

pedro-w commented 3 years ago

OK, no warnings or errors if I start emacs with EMACSLOADPATH=$(pwd): emacs -q then recompile all files. As far as I can tell this is ready for merging.